dannc/spring-boot-demo
1
0
Fork 0
mirror of https://github.com/Dannecron/spring-boot-demo.git synced 2025-12-26 08:42:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

add send method to product service

Browse Source
This commit is contained in:
Savosin Denis
2025-06-03 11:34:28 +07:00
parent 1bda2e1d21
commit a8639f8d15
8 changed files with 80 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/main/kotlin/com/github/dannecron/demo/http/controllers/ProductController.kt
View File

@@ -2,6 +2,7 @@ package com.github.dannecron.demo.http.controllers
import com.github.dannecron.demo.core.dto.Product
import com.github.dannecron.demo.core.exceptions.AlreadyDeletedException
import com.github.dannecron.demo.core.exceptions.InvalidDataException
import com.github.dannecron.demo.core.exceptions.ProductNotFoundException
import com.github.dannecron.demo.core.services.product.ProductService
import com.github.dannecron.demo.http.exceptions.NotFoundException
@@ -10,8 +11,6 @@ import com.github.dannecron.demo.http.requests.CreateProductRequest
import com.github.dannecron.demo.http.responses.NotFoundResponse
import com.github.dannecron.demo.http.responses.makeOkResponse
import com.github.dannecron.demo.http.responses.page.PageResponse
import com.github.dannecron.demo.services.ProductSyncService
import com.github.dannecron.demo.services.kafka.exceptions.InvalidArgumentException
import io.swagger.v3.oas.annotations.media.Content
import io.swagger.v3.oas.annotations.media.Schema
import io.swagger.v3.oas.annotations.responses.ApiResponse
@@ -29,7 +28,6 @@ import java.util.*
@RequestMapping(value = ["/api/product"], produces = [MediaType.APPLICATION_JSON_VALUE])
class ProductController(
private val productService: ProductService,
private val productSyncService: ProductSyncService,
) {
@GetMapping("/{guid}")
@Throws(NotFoundException::class)
@@ -73,8 +71,8 @@ class ProductController(
@RequestParam(required = false) topic: String?
): ResponseEntity<Any> {
try {
productSyncService.syncToKafka(guid, topic)
} catch (_: InvalidArgumentException) {
productService.send(guid, topic)
} catch (_: InvalidDataException) {
throw UnprocessableException("cannot sync product to kafka")
}

11
src/test/kotlin/com/github/dannecron/demo/http/controllers/ProductControllerTest.kt
View File

@@ -4,7 +4,6 @@ import com.github.dannecron.demo.BaseUnitTest
import com.github.dannecron.demo.core.dto.Product
import com.github.dannecron.demo.core.services.product.ProductService
import com.github.dannecron.demo.http.responses.ResponseStatus
import com.github.dannecron.demo.services.ProductSyncService
import org.hamcrest.Matchers.contains
import org.hamcrest.Matchers.nullValue
import org.junit.jupiter.api.Test
@@ -39,9 +38,6 @@ class ProductControllerTest: BaseUnitTest() {
@MockBean
private lateinit var productService: ProductService
@MockBean
private lateinit var productSyncService: ProductSyncService
private val guid = UUID.randomUUID()
private val now = OffsetDateTime.now()
private val productId = 12L
@@ -72,7 +68,6 @@ class ProductControllerTest: BaseUnitTest() {
.andExpect { jsonPath("\$.updatedAt") { value(nullValue()) } }
verify(productService, times(1)).findByGuid(guid)
verifyNoInteractions(productSyncService)
}
@Test
@@ -85,7 +80,6 @@ class ProductControllerTest: BaseUnitTest() {
.andExpect { jsonPath("\$.status") { value(ResponseStatus.NOT_FOUND.status) } }
verify(productService, times(1)).findByGuid(guid)
verifyNoInteractions(productSyncService)
}
@Test
@@ -109,7 +103,6 @@ class ProductControllerTest: BaseUnitTest() {
.andExpect { jsonPath("\$.data[0].isDeleted") { value(false) } }
verify(productService, times(1)).findAll(pageRequest)
verifyNoInteractions(productSyncService)
}
@Test
@@ -127,7 +120,6 @@ class ProductControllerTest: BaseUnitTest() {
.andExpect { jsonPath("\$.id") { value(productId) } }
verify(productService, times(1)).create(productName, productPrice, null)
verifyNoInteractions(productSyncService)
}
@Test
@@ -144,7 +136,6 @@ class ProductControllerTest: BaseUnitTest() {
.andExpect { jsonPath("\$.cause") { contains("name") } }
verifyNoInteractions(productService)
verifyNoInteractions(productSyncService)
}
@Test
@@ -161,7 +152,6 @@ class ProductControllerTest: BaseUnitTest() {
.andExpect { jsonPath("\$.cause") { value(MethodArgumentNotValidException::class.qualifiedName) } }
verifyNoInteractions(productService)
verifyNoInteractions(productSyncService)
}
@Test
@@ -176,6 +166,5 @@ class ProductControllerTest: BaseUnitTest() {
.andExpect { jsonPath("\$.status") { value(ResponseStatus.OK.status) } }
verify(productService, times(1)).delete(guid)
verifyNoInteractions(productSyncService)
}
}